feat(slider): add component tokens #10716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DitwanP
changed the title
DitwanP
added
skip visual snapshots
…nto dit13711/7180-add-tokens-to-slider
|
we are not adding tokens for outline-color and I don't think this component needs stateful tokens |
@alisonailea |
We may in the future. For now, here's a list of our tokenizable styles |
alisonailea
reviewed
Nov 13, 2024
…nto dit13711/7180-add-tokens-to-slider
…nto dit13711/7180-add-tokens-to-slider
…nto dit13711/7180-add-tokens-to-slider
…nto dit13711/7180-add-tokens-to-slider
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add tokens for the slider component, e2e, and custom-theme chromatic tests. (WIP)
Slider Tokens
--calcite-slider-text-color: Specifies the component's text color.--calcite-slider-track-color: Specifies the component's track color.--calcite-slider-track-fill-color: Specifies the component's fill track color.--calcite-slider-handle-fill-color: Specifies the component's handle fill color.--calcite-slider-handle-extension-color: Specifies the component's handle extension color.--calcite-slider-tick-color: Specifies the component's tick color.--calcite-slider-tick-border-color: Specifies the component's tick border color.--calcite-slider-tick-selected-color: Specifies the component's tick color when in selected range.--calcite-slider-graph-color: Specifies the component's graph color.